Skip to content

Conversation

@martincostello
Copy link
Owner

Scan GitHub Actions workflows with zizmor and fix/suppress findings.

Scan GitHub Actions workflows with zizmor and fix/suppress findings.
Copilot AI review requested due to automatic review settings August 15, 2025 12:14
@martincostello martincostello added enhancement New feature or request dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Aug 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates zizmor, a GitHub Actions workflow security scanner, into the project's CI/CD pipeline and addresses findings from the security analysis. The changes add zizmor scanning to the lint workflow while suppressing specific security warnings where the current configuration is intentionally required.

  • Adds zizmor security scanning to the lint workflow with pedantic persona
  • Suppresses zizmor findings for intentional security configurations with explanatory comments
  • Updates workflow permissions to support zizmor's security scanning capabilities

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/lint.yml Adds zizmor workflow scanning step with required permissions and environment variables
.github/workflows/release.yml Suppresses artipacked warning for persist-credentials with justification comment
.github/workflows/ossf-scorecard.yml Suppresses excessive-permissions warning for OSSF Scorecard recommended permissions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@martincostello martincostello merged commit 2a8f270 into main Aug 15, 2025
6 checks passed
@martincostello martincostello deleted the add-zizmor branch August 15, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants